Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): adds missing @types/node dependency #1

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

Addono
Copy link
Member

@Addono Addono commented Nov 21, 2021

Without it, TypeScript cannot infer the types from e.g. process:

tscli/cli.ts

Line 7 in 680d0c5

const args = yargs(process.argv.slice(2))

@Addono Addono added the bug Something isn't working label Nov 21, 2021
@Addono Addono requested a review from mrako November 21, 2021 13:49
@Addono Addono self-assigned this Nov 21, 2021
@Addono
Copy link
Member Author

Addono commented Nov 21, 2021

Not entirely sure why it didn't require it. Checking out main and npm ci-ing now doesn't show any errors. I presume it's already installed through a transitive dependency.

Anyway, it's in general nice to have @types/node checked into your package-lock as well, since it allows explicitely defining the major Node.js version you're running against.

@mrako mrako merged commit 624068d into main Nov 21, 2021
@mrako mrako deleted the fix/adds-missing-@types/node-dependency branch November 21, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants