Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: Inform about dead link when C-c d f #119

Open
buhtz opened this issue Sep 19, 2021 · 4 comments
Open

FeatureRequest: Inform about dead link when C-c d f #119

buhtz opened this issue Sep 19, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@buhtz
Copy link

buhtz commented Sep 19, 2021

When I do C-c d f on a zettel-link which is dead because there is no zettel behind it with that name nothing happens.
I would like to have minimal message in the "status buffer" (or how it is called in emacs) about that "problem".

As a novice emacs and zetteldeft user somebody would think she/he is doinng something wrong.
The user should know and understand why the follow-link does not happen.

@EFLS EFLS added the enhancement New feature or request label Sep 19, 2021
@EFLS
Copy link
Owner

EFLS commented Sep 19, 2021

Great suggestion! Currently I don't have much time to work on Zetteldeft, but it should be trivial to add something like this to zetteldeft--search-filename.

@EFLS
Copy link
Owner

EFLS commented Sep 19, 2021

Eh, so I've already pushed a change that includes this. Try it out and let me know if it works as you'd expect. Thanks for the suggestion, as being verbose towards (new) users is important for usability.

EDIT: Also, FYI, there is zetteldeft-dead-links-buffer that shows all dead links in your Zetteldeft

@buhtz
Copy link
Author

buhtz commented Sep 19, 2021

Wow! You should win a price for the fastes and full resolved feature request! 🗡️
It work's fine.

Just a side question about emacs deploy infrastructure.
Your commit appeared at MELPA. Why?
Is it done automaticly? Does MELPA always represent the upstream repo status?
Or did you triggered it explicit?

EDIT: Also for C-c d F the error messags appears. But the "new window" is opened also. I would say there is no need to open a new window when there is no note found.

@buhtz buhtz closed this as completed Sep 19, 2021
@EFLS
Copy link
Owner

EFLS commented Sep 19, 2021

Ah yes, the new window variant should be taken care of too. Might be a tad more complex though.

With regards to MELPA: AFAIK MELPA keeps track of this repo and updates its packages automatically (within a day or so). No triggering on my part.

@EFLS EFLS reopened this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants