Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested spacemacs keys #33

Closed
brunosmmm opened this issue Feb 13, 2020 · 1 comment · Fixed by #34
Closed

Suggested spacemacs keys #33

brunosmmm opened this issue Feb 13, 2020 · 1 comment · Fixed by #34

Comments

@brunosmmm
Copy link
Contributor

brunosmmm commented Feb 13, 2020

I've actually implemented zetteldeft support under the deft layer in spacemacs, and that has been merged into the develop branch: syl20bnr/spacemacs#13256.

I was thinking about submitting a pull request with updated documentation in the section with "suggested keybindings", however I started to second guess myself about what would be appropriate - mentioning enabling zetteldeft support in spacemacs, which comes with keybindings already setup (those are actually different from the currently suggested) AND/OR (keeping/removing) current suggestions.

Any ideas? If I get any pointers, I'll modify the docs accordingly and submit a PR.

Edit: reference PR instead of commit on spacemacs repo

@EFLS
Copy link
Owner

EFLS commented Feb 13, 2020

That's awesome! Please do make changes to the relevant section as you see fit. If there are much differences, it might be best indeed to add them under a separate heading. But the fact that there is a way to enable all of those with a single variable is very nice.

Could you also include an overview of the bindings, perhaps a table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants