Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when image is nil #10

Merged
merged 3 commits into from
May 12, 2017
Merged

Fix crash when image is nil #10

merged 3 commits into from
May 12, 2017

Conversation

mlight3
Copy link
Contributor

@mlight3 mlight3 commented May 12, 2017 •
edited
Loading

image property is optional, but texture property is not optional.
So when I init with image nil, app crashes in selectedAnimation func.

And also configure func is open func. I can set image to nil after init.
But texture is not changed because of guard statement.

@efremidze efremidze merged commit 2dfea09 into efremidze:master May 12, 2017
@mlight3
Copy link
Contributor Author

mlight3 commented May 12, 2017

Wow! Super fast!

efremidze pushed a commit that referenced this pull request Aug 3, 2018
@mlight3 @efremidze
Fix crash when image is nil (#10)
c04d059 
* Convert `texture` property to optional

* Add `init` func default value for image parameter

* Set `texture` nil when image is nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlight3 @efremidze