Review layout to make sure buttons adapt to their contents, for long translations #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pirishd Thanks so much! I plan to review and merge this tomorrow. All looks good though. |
|
Hi @mikemee, do you know when that could be merged? Can I help in some ways? |
mikemee
approved these changes
Oct 8, 2017
|
@pirishd Release in 1.4.9. Many thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As texts may be cut in buttons for some languages like French and Russian (see Issue #23), I made sure buttons adapt to their contents by:
wrap_contentfor their layout heightsdimen.xmlfile