fix: should support windows and Node.js 14 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 79.61% // Head: 100.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
============================================
+ Coverage 79.61% 100.00% +20.38%
============================================
Files 25 13 -12
Lines 785 95 -690
Branches 141 19 -122
============================================
- Hits 625 95 -530
+ Misses 139 0 -139
+ Partials 21 0 -21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fengmk2
commented
Feb 16, 2023
scripts/start-cluster.js
Outdated
| @@ -1,6 +1,11 @@ | |||
| const debug = require('util').debuglog('egg-bin:lib:start-cluster'); | |||
|
|
|||
| debug('argv: %o', process.argv); | |||
| const options = JSON.parse(process.argv[2]); | |||
| let optionsJSONString = process.argv[2]; | |||
| if (process.platform === 'win32' && optionsJSONString.startsWith('\'')) { | |||
There was a problem hiding this comment.
拿到后变成啥样子了？ 我印象中很多年前也是写 egg-scripts 时，被 win 的字符串转译搞疯了
atian25
reviewed
Feb 16, 2023
|
artus-cli/artus-cli#32 exit code 总是 0 的问题 |
fengmk2
pushed a commit
that referenced
this pull request
Feb 17, 2023
[skip ci] ## [6.1.2](v6.1.1...v6.1.2) (2023-02-17) ### Bug Fixes * should support windows and Node.js 14 ([#223](#223)) ([8f1b709](8f1b709))
|
🎉 This PR is included in version 6.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
close eggjs/egg#5146