Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix execArgv not work in cov #254

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix: fix execArgv not work in cov #254

merged 3 commits into from
Feb 20, 2024

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Feb 20, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
egg-bin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 0:27am

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (090e765) 100.00% compared to head (7c9dbc9) 100.00%.
Report is 1 commits behind head on 5.x.

Additional details and impacted files
@@            Coverage Diff            @@
##               5.x      #254   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines           93        93           
  Branches        16        16           
=========================================
  Hits            93        93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killagu killagu merged commit a31f9b4 into 5.x Feb 20, 2024
14 of 15 checks passed
@killagu killagu deleted the fix/cov_exec_argv branch February 20, 2024 12:42
fengmk2 pushed a commit that referenced this pull request Feb 20, 2024
[skip ci]

## [5.15.1](v5.15.0...v5.15.1) (2024-02-20)

### Bug Fixes

* fix execArgv not work in cov ([#254](#254)) ([a31f9b4](a31f9b4))
killagu added a commit that referenced this pull request Mar 3, 2024
<!--
Thank you for your pull request. Please review below requirements.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide:
https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md

感谢您贡献代码。请确认下列 checklist 的完成情况。
Bug 修复和新功能必须包含测试,必要时请附上性能测试。
Contributors guide:
https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md
-->

<!-- Remove items that do not apply. For completed items, change [ ] to
[x]. -->

- [ ] `npm test` passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows commit guidelines

<!-- Provide affected core subsystem(s). -->

<!-- Provide a description of the change below this comment. -->
killagu added a commit that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants