Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/framework error #10

Merged
merged 9 commits into from
Mar 19, 2021
Merged

Feat/framework error #10

merged 9 commits into from
Mar 19, 2021

Conversation

mansonchor
Copy link
Member

add FrameworkBaseError and formatter

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #10 (1512028) into master (4000f02) will decrease coverage by 0.27%.
The diff coverage is 96.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #10      +/-   ##
===========================================
- Coverage   100.00%   99.72%   -0.28%     
===========================================
  Files           50       52       +2     
  Lines          341      366      +25     
  Branches        48       52       +4     
===========================================
+ Hits           341      365      +24     
- Partials         0        1       +1     
Impacted Files Coverage Δ
lib/base.ts 100.00% <ø> (ø)
lib/framework/formatter.ts 92.30% <92.30%> (ø)
lib/framework/framework_base_error.ts 100.00% <100.00%> (ø)
lib/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4000f02...1512028. Read the comment docs.

lib/framework/framework_base_error.ts Outdated Show resolved Hide resolved
lib/framework/framework_base_error.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/framework/framework_base_error.test.ts Show resolved Hide resolved
lib/framework/formatter.ts Outdated Show resolved Hide resolved
Copy link

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansonchor mansonchor merged commit cae5451 into master Mar 19, 2021
@killagu killagu deleted the feat/framework-error branch March 19, 2021 11:12
@mansonchor
Copy link
Member Author

  • egg-errors@2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants