feat: remove 4.x support & fix test #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 10 6 -4
=====================================
- Hits 10 6 -4
Continue to review full report at Codecov.
|
popomore
approved these changes
Feb 21, 2017
fengmk2
reviewed
Feb 21, 2017
.autod.conf.js
Outdated
| @@ -4,8 +4,8 @@ module.exports = { | |||
| write: true, | |||
| prefix: '^', | |||
| test: [ | |||
| 'test', | |||
| 'benchmark', | |||
| 'test', | |||
fengmk2
reviewed
Feb 21, 2017
README.md
Outdated
| @@ -22,6 +22,8 @@ | |||
|
|
|||
| Wrap [koa-etag](https://github.com/koajs/etag) and [koa-conditional-get](https://github.com/koajs/conditional-get) for egg | |||
|
|
|||
| **We recommend to use nginx to do this for better performance rather than use this plugin.** | |||
There was a problem hiding this comment.
[nginx etag](http://nginx.org/en/docs/http/ngx_http_core_module.html#etag)
fengmk2
reviewed
Feb 21, 2017
| @@ -7,22 +7,21 @@ | |||
| }, | |||
| "keywords": [ | |||
| "egg", | |||
| "eggPlugin", | |||
| "egg-plugin" | |||
huacnlee
requested changes
Feb 21, 2017
README.zh_CN.md
Outdated
| @@ -26,6 +26,8 @@ | |||
|
|
|||
| 此功能在一些内容变化不多的场景，能有效避免网络下载。 | |||
|
|
|||
| **通常来说，基于性能方面的考虑，在生产环境我们会使用 nginx 替代该插件来计算 etag 。** | |||
There was a problem hiding this comment.
nginx -> Nginx
etag -> ETag
atian25
force-pushed
the
remove-4
branch
2 times, most recently
from
f54f559
to
4c8f779
Compare
|
done, review again |
|
ping @huacnlee, need more +1 |
huacnlee
reviewed
Feb 21, 2017
README.md
Outdated
| @@ -22,6 +22,8 @@ | |||
|
|
|||
| Wrap [koa-etag](https://github.com/koajs/etag) and [koa-conditional-get](https://github.com/koajs/conditional-get) for egg | |||
|
|
|||
| **For better performance, we recommend to use [Nginx Etag](http://nginx.org/en/docs/http/ngx_http_core_module.html#etag) rather than use this plugin.** | |||
huacnlee
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change