fix: allow to call mockHttpclient multi times #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Nov 7, 2023
killagu
reviewed
Nov 7, 2023
lib/mock_httpclient.js
Outdated
| return mockUrl.test(`${requestOrigin}${path}`); | ||
| for (const config of mockConfigs) { | ||
| if (config.mockUrl.test(`${requestOrigin}${path}`)) { | ||
| mm(app, '__httpclientNextMockConfigIndex', config.mockConfigIndex); |
There was a problem hiding this comment.
两次 mock，Promose.all 中的请求都匹配了。
fengmk2
commented
Nov 8, 2023
| app.mockHttpclient(/\/mock_url/, { | ||
| data: Buffer.from('mock 1 match response'), | ||
| }); | ||
| app.mockHttpclient(/\/mock_url/, { |
There was a problem hiding this comment.
加了相同 mock 校验，只会返回第一个 mock 结果
fengmk2
commented
Nov 8, 2023
| @@ -63,6 +63,9 @@ module.exports = app => { | |||
| * @return {Context} this | |||
| */ | |||
|
|
|||
| const MOCK_CONFIGS = Symbol('MOCK_CONFIGS'); | |||
| const MOCK_CONFIG_INDEX = Symbol('MOCK_CONFIG_INDEX'); | |||
fengmk2
pushed a commit
that referenced
this pull request
Nov 8, 2023
[skip ci] ## [5.10.9](v5.10.8...v5.10.9) (2023-11-08) ### Bug Fixes * allow to call mockHttpclient multi times ([#165](#165)) ([370e42d](370e42d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #164
Checklist
npm testpassesAffected core subsystem(s)
Description of change