-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use async function and support egg@2 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
不再兼容 egg 1 形式的 role 定义,因为 koa-roles 已经无法兼容了 |
那 README 要写一个迁移指南? |
不用了,API 太简单了,codemod 来搞 |
@eggjs/core 看看 |
+1 codemod 那个我没思路... 你搞吧 |
恩, codemod 会先搞内部的,现在我也是优先解决内部用到的中间件。 |
https://eggjs.org/zh-cn/migration.html 想了想,这里还是要加一个章节加上所有官方维护插件的变更说明的。 |
+1 |
@atian25 可以写 |
嗯,不过可以要找 @dead-horse 给个大概描述啥的,插件大部分是他升级的。 我正在看怎么把 migration 和 async-function 这两个文档合并,后者感觉存在的价值不太大了。或者把前者的 yieldable -> awaitable 移入后者去。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesAffected core subsystem(s)
Description of change