New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use async function and support egg@2 #9

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@dead-horse
Member

dead-horse commented Nov 23, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@dead-horse dead-horse requested review from fengmk2 and popomore Nov 23, 2017

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Nov 23, 2017

Member

不再兼容 egg 1 形式的 role 定义,因为 koa-roles 已经无法兼容了

Member

dead-horse commented Nov 23, 2017

不再兼容 egg 1 形式的 role 定义,因为 koa-roles 已经无法兼容了

@dead-horse dead-horse referenced this pull request Nov 23, 2017

Closed

V2 #1564

26 of 29 tasks complete
@atian25

This comment has been minimized.

Show comment
Hide comment
@atian25

atian25 Nov 23, 2017

Member

那 README 要写一个迁移指南?

Member

atian25 commented Nov 23, 2017

那 README 要写一个迁移指南?

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Nov 23, 2017

Member

不用了,API 太简单了,codemod 来搞

Member

dead-horse commented Nov 23, 2017

不用了,API 太简单了,codemod 来搞

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse
Member

dead-horse commented Nov 23, 2017

@eggjs/core 看看

@atian25

This comment has been minimized.

Show comment
Hide comment
@atian25

atian25 Nov 23, 2017

Member

+1

codemod 那个我没思路... 你搞吧

Member

atian25 commented Nov 23, 2017

+1

codemod 那个我没思路... 你搞吧

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Nov 23, 2017

Member

恩, codemod 会先搞内部的,现在我也是优先解决内部用到的中间件。

Member

dead-horse commented Nov 23, 2017

恩, codemod 会先搞内部的,现在我也是优先解决内部用到的中间件。

@dead-horse dead-horse merged commit 1919cc1 into master Nov 23, 2017

4 of 6 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details

@dead-horse dead-horse deleted the egg2 branch Nov 23, 2017

@atian25

This comment has been minimized.

Show comment
Hide comment
@atian25

atian25 Nov 23, 2017

Member

https://eggjs.org/zh-cn/migration.html

想了想,这里还是要加一个章节加上所有官方维护插件的变更说明的。

Member

atian25 commented Nov 23, 2017

https://eggjs.org/zh-cn/migration.html

想了想,这里还是要加一个章节加上所有官方维护插件的变更说明的。

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Nov 23, 2017

Member

+1

Member

fengmk2 commented Nov 23, 2017

+1

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Nov 23, 2017

Member

@atian25 可以写

Member

fengmk2 commented Nov 23, 2017

@atian25 可以写

@atian25

This comment has been minimized.

Show comment
Hide comment
@atian25

atian25 Nov 23, 2017

Member

嗯,不过可以要找 @dead-horse 给个大概描述啥的,插件大部分是他升级的。

我正在看怎么把 migration 和 async-function 这两个文档合并,后者感觉存在的价值不太大了。或者把前者的 yieldable -> awaitable 移入后者去。

Member

atian25 commented Nov 23, 2017

嗯,不过可以要找 @dead-horse 给个大概描述啥的,插件大部分是他升级的。

我正在看怎么把 migration 和 async-function 这两个文档合并,后者感觉存在的价值不太大了。或者把前者的 yieldable -> awaitable 移入后者去。

@atian25

This comment has been minimized.

Show comment
Hide comment
Member

atian25 commented Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment