Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache can be disable #2

Merged
merged 1 commit into from
Feb 28, 2017
Merged

fix: cache can be disable #2

merged 1 commit into from
Feb 28, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented Feb 28, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Feb 28, 2017

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      6    +1     
  Lines          87     88    +1     
=====================================
+ Hits           87     88    +1
Impacted Files Coverage Δ
lib/view_manager.js 100% <100%> (ø)
config/config.local.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f663d3...580c478. Read the comment docs.

@popomore
Copy link
Member Author

合了

@popomore popomore merged commit 56058aa into master Feb 28, 2017
@popomore popomore deleted the disable-cache branch February 28, 2017 12:52
@popomore
Copy link
Member Author

  • egg-view@1.0.1

// check cache
let filename = this.fileMap.get(name);
if (filename) return filename;
if (config.cache && filename) return filename;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非 cache 就将下面的 set cache 也删除了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants