test: fix tsc test case #1620
Merged
test: fix tsc test case #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
commented
Nov 7, 2017
test/ts/index.test.js
Outdated
| yield runscript('tsc', { cwd: baseDir }); | ||
| const dest = path.join(baseDir, 'node_modules/egg'); | ||
| rimraf.sync(dest); | ||
| mkdirp.sync(path.dirname(dest)); |
There was a problem hiding this comment.
don't use npm link, it will reinstall all the node_modules
There was a problem hiding this comment.
const mkdirp = require('mz-modules/mkdirp');
const rimraf = require('mz-modules/rimraf');
const fs = require('mz/fs');
yield rimraf(dest);
yield mkdirp(path.dirname(dest));
yield fs.symlink('../../../../../', dest);
Codecov Report
@@ Coverage Diff @@
## master #1620 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 29 29
Lines 715 715
=======================================
Hits 713 713
Misses 2 2Continue to review full report at Codecov.
|
atian25
approved these changes
Nov 7, 2017
package.json
Outdated
| @@ -69,8 +69,10 @@ | |||
| "formstream": "^1.1.0", | |||
| "glob": "^7.1.2", | |||
| "koa-static": "^3.0.0", | |||
| "mkdirp": "^0.5.1", | |||
test/ts/index.test.js
Outdated
| yield runscript('tsc', { cwd: baseDir }); | ||
| const dest = path.join(baseDir, 'node_modules/egg'); | ||
| rimraf.sync(dest); | ||
| mkdirp.sync(path.dirname(dest)); |
There was a problem hiding this comment.
const mkdirp = require('mz-modules/mkdirp');
const rimraf = require('mz-modules/rimraf');
const fs = require('mz/fs');
yield rimraf(dest);
yield mkdirp(path.dirname(dest));
yield fs.symlink('../../../../../', dest);
atian25
approved these changes
Nov 7, 2017
popomore
approved these changes
Nov 7, 2017
popomore
pushed a commit
that referenced
this pull request
Nov 7, 2017
test: fix tsc test case (#1620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change