Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade egg-core@4 #1631

Merged
merged 4 commits into from
Nov 9, 2017
Merged

refactor: upgrade egg-core@4 #1631

merged 4 commits into from
Nov 9, 2017

Conversation

dead-horse
Copy link
Member

@dead-horse dead-horse commented Nov 8, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

#1564

@dead-horse
Copy link
Member Author

dead-horse commented Nov 8, 2017

插件还没有升级,但是现在是兼容的,先合并发布一个 egg@2.0.0-beta.1,让插件可以测试。

@fengmk2
Copy link
Member

fengmk2 commented Nov 8, 2017

可以切一个 1.x 分支出来了。

@fengmk2
Copy link
Member

fengmk2 commented Nov 8, 2017

package.json 里面先加一个 next tag 作为 publish tag 吧

@codecov-io
Copy link

codecov-io commented Nov 8, 2017

Codecov Report

Merging #1631 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
- Coverage   99.72%   99.57%   -0.15%     
==========================================
  Files          29       29              
  Lines         715      712       -3     
==========================================
- Hits          713      709       -4     
- Misses          2        3       +1
Impacted Files Coverage Δ
app/middleware/notfound.js 100% <100%> (ø) ⬆️
app/middleware/meta.js 100% <100%> (ø) ⬆️
lib/egg.js 100% <100%> (ø) ⬆️
app/middleware/site_file.js 100% <100%> (ø) ⬆️
app/extend/context.js 100% <100%> (ø) ⬆️
app/extend/request.js 98.82% <0%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b586a23...3502286. Read the comment docs.

appveyor.yml Outdated
@@ -1,6 +1,5 @@
environment:
matrix:
- nodejs_version: '6'
- nodejs_version: '7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没变为 8, 9 ?

@dead-horse
Copy link
Member Author

合并了

@dead-horse dead-horse merged commit 8e8869a into master Nov 9, 2017
@atian25 atian25 deleted the egg-core-4 branch November 9, 2017 01:33
popomore pushed a commit that referenced this pull request Nov 9, 2017
refactor: upgrade egg-core@4 (#1631)
popomore pushed a commit that referenced this pull request Nov 9, 2017
refactor: upgrade egg-core@4 (#1631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants