test: mv assert to fixtures #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thonatos
force-pushed
the
test/fix-win-ci
branch
from
231a7c3
to
0985c17
Compare
Codecov Report
@@ Coverage Diff @@
## master #3829 +/- ##
======================================
Coverage 100% 100%
======================================
Files 34 34
Lines 945 945
======================================
Hits 945 945Continue to review full report at Codecov.
|
thonatos
force-pushed
the
test/fix-win-ci
branch
from
0985c17
to
fb68930
Compare
thonatos
changed the title
thonatos
force-pushed
the
test/fix-win-ci
branch
3 times, most recently
from
ad27040
to
3d6ea5a
Compare
thonatos
changed the title
thonatos
changed the title
atian25
reviewed
Jul 19, 2019
| @@ -168,15 +168,8 @@ describe('test/lib/egg.test.js', () => { | |||
| const baseDir = utils.getFilepath('apps/dumpconfig'); | |||
| let json; | |||
|
|
|||
| await sleep(100); | |||
There was a problem hiding this comment.
这里不能删掉吧，dump config 会执行两次的，这里是分别在 ready 前后校验
There was a problem hiding this comment.
改了，移动到 fixtures 下 app.js 里了，这样就不用担心读取时机不对了，老板霸气~
thonatos
force-pushed
the
test/fix-win-ci
branch
from
3d6ea5a
to
f2b9c4d
Compare
thonatos
changed the title
thonatos
force-pushed
the
test/fix-win-ci
branch
from
f2b9c4d
to
580fc9b
Compare
atian25
reviewed
Jul 22, 2019
atian25
approved these changes
Jul 22, 2019
popomore
pushed a commit
that referenced
this pull request
Jul 22, 2019
test: mv assert to fixtures (#3829)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
由于
dumpConfig在app.ready()前后各一次，且创建时间无法确定，通过sleep方法检测在win存在不确定性，将其移动到fixtures下app.js中使用文件读取的方式进行检测。