Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set consoleLevel WARN of coreLogger in local #850

Merged
merged 2 commits into from
May 5, 2017
Merged

Conversation

popomore
Copy link
Member

@popomore popomore commented May 5, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

This config is removed by PR #695,
but the infomation of coreLogger is not useful for app developer,
and this config won't changed by app developer

This config is removed by PR #695,
but the infomation of coreLogger is not useful for app developer,
and this config won't changed by app developer
@mention-bot
Copy link

@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 to be a potential reviewer.

@popomore popomore requested a review from fengmk2 May 5, 2017 12:14
@popomore
Copy link
Member Author

popomore commented May 5, 2017

@atian25 这个配置还加回来

@codecov
Copy link

codecov bot commented May 5, 2017

Codecov Report

Merging #850 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #850   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     28    +1     
  Lines         666    667    +1     
=====================================
+ Hits          666    667    +1
Impacted Files Coverage Δ
config/config.local.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af174ef...1e2a518. Read the comment docs.

@fengmk2 fengmk2 merged commit bd0a827 into master May 5, 2017
@fengmk2 fengmk2 deleted the corelogger branch May 5, 2017 14:02
@fengmk2
Copy link
Member

fengmk2 commented May 5, 2017

应该发patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants