Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update serialization namespace #24

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

tanczosm
Copy link
Collaborator

Small fix with adjusting namespaces. The namespace for the serialization classes has been updated from Htmxor.Configuration.Serialization to Htmxor.Serialization. This change affects multiple files including HtmxHeadOutlet.cs, HtmxResponse.cs, and HtmxJsonSerializerContext.cs.

The namespace for the serialization classes has been updated from `Htmxor.Configuration.Serialization` to `Htmxor.Serialization`. This change affects multiple files including `HtmxHeadOutlet.cs`, `HtmxResponse.cs`, and `HtmxJsonSerializerContext.cs`.
Copy link
Owner

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch.

@egil
Copy link
Owner

egil commented Apr 30, 2024

Looks like there is a build error.

Error: /home/runner/work/Htmxor/Htmxor/src/Htmxor/HtmxConfig.cs(5,14): error CS0234: The type or namespace name 'Configuration' does not exist in the namespace 'Htmxor' (are you missing an assembly reference?) [/home/runner/work/Htmxor/Htmxor/src/Htmxor/Htmxor.csproj]

Removed an unnecessary import from the HtmxConfig file, specifically the Configuration.Serialization namespace which was not being used. This helps to keep the codebase clean and efficient.
Removed the unnecessary Htmxor.Configuration import from the _Imports.razor file in the HtmxBlazorSSR project. This simplifies the code and reduces dependencies.
@egil egil merged commit fba9139 into egil:main Apr 30, 2024
7 checks passed
@egil
Copy link
Owner

egil commented Apr 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants