feat:use the build api instead of transform api to support inject etc. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would also let us use plugins |
|
🎉 🙏 |
|
@reconbot plugins is not possible with sync api |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i just add this feature beacause i meet some demand that the same as this issue from esbuild,but the temporary solution will need the build api inject option,so i just turned to find if it have the same effect options in transform api.
but unfortunately,i only found this issue,the author of esbuild said that he was considering removing the transform API in the future and just having people use the build API instead,so i begin to investigate into how to use build api instead of transform api and i found the stdin and wirte options will make the build api work like the transform api in a simple way and support more feature.