Timer intervals revised #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gazj
commented
Feb 24, 2018
gazj
commented
- Added function to replace text with "scifi" text
- Added 'keepChars' array option to prevent replacing certain characters
- Invervals are now responsible for clearing themselves
- Expose interval continues until reaching end of content string
- Scifi interval continues until display text matches original content
- Config values renamed to 'scifiSpeed' and 'exposeDelay' for clarity
- Support added for using a scifiSpeed higher than exposeDelay value
- Added function to replace text with "scifi" text - Added 'keepChars' array option to prevent replacing certain characters - Invervals are now responsible for clearing themselves - Expose interval continues until reaching end of content string - Scifi interval continues until display text matches original content - Config values renamed to 'scifiSpeed' and 'exposeDelay' for clarity - Support added for using a scifiSpeed higher than exposeDelay value
egoist
requested changes
Feb 24, 2018
src/getRandomChar.js
Outdated
| function toScifiText(chars, text, keepChars) { | ||
| let retChars = '' | ||
| for (let i = 0; i < text.length; i++) { | ||
| retChars += keepChars.includes(text[i]) ? text[i] : getRandomChar(chars) |
There was a problem hiding this comment.
maybe use .indexOf for IE compatibility 😄
added 4 commits
February 24, 2018 09:09
|
I've switched to using |
egoist
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.