Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix when no options provided #1

Merged
merged 2 commits into from
Feb 22, 2018
Merged

fix when no options provided #1

merged 2 commits into from
Feb 22, 2018

Conversation

miljan-aleksic
Copy link
Contributor

@miljan-aleksic miljan-aleksic commented Feb 22, 2018 •
edited
Loading

loaderUtils.getOptions returns null if no options provided, value that cannot be destructured and resulting in a TypeError: Cannot match against 'undefined' or 'null' error when run on vmark.

@egoist egoist merged commit 33255be into egoist:master Feb 22, 2018
@egoist egoist mentioned this pull request Feb 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miljan-aleksic @egoist