Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EMF-Model to LocalDateTime #9

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Conversation

fgdrf
Copy link

@fgdrf fgdrf commented Oct 23, 2021

rather than org.joda.time.DataTime

Signed-off-by: Frank Gasdorf fgdrf@users.sourceforge.net

rather than org.joda.time.DataTime

Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Copy link
Author

@fgdrf fgdrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of this changes are whitespace "fixes" done by EMF code generator with t he current formatter setting.

Comment on lines +94 to 96
eType="#//LocalDateTime"/>
<eStructuralFeatures xsi:type="ecore:EAttribute" name="currentTimestep" eType="#//LocalDateTime"/>
<eStructuralFeatures xsi:type="ecore:EAttribute" name="availableElevation" upperBound="-1"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egouge Do you have any idea how change a model to keep compatible to the current used model? Since the dependency is gone anyway, there might be no other option than increasing the major version.

However. My read of DataTime "functionality" : There is no functionality in uDig to work with availableTimesteps yet. What do you think about removing it completely from the model and generated classes?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgdrf I'm all for removing it - I couldn't figure out what it was for really. However, it does look like the NavigationView of the jgrass tools was using it; however I could probably update this to store it locally rather than in the viewportmodel. Do you want me to go ahead and try this and see what comes of it?

@@ -801,8 +799,8 @@ public EDataType getReferencedEnvelope() {
* @generated
*/
@Override
public EDataType getDateTime() {
return dateTimeEDataType;
public EDataType getLocalDateTime() {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a compile issue since method signeture is not defined in any interface. Wondering where getDateTime() is been defined ..

I'm not very familiar with EMF Model and generation of classes out of it. Looks like I forgot something .. Any idea?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right sorry, I totally forgot about the EMF stuff. I don't really know much about it either - I'll have a look.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I figured out where the issues was and regenerated the emf packages. Have a look at let me know what else I've missed. Thanks.

@egouge egouge merged commit 64ab395 into egouge:datetimeup Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants