Fix support for nullary unstable functions #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves egraphs-good#382 by adding parsing support for defining sorts of 0 argument unstable functions. It does this by handling that input `()` as the `Unit` constructor. If we ever want to remove the Unit constructor, we could move the return type to the list of argument types, to make sure it always has at least one value. This would also make parsing it more similar to other datatypes. For now I just kept it the same to make the change minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #382 by adding parsing support for defining sorts of 0 argument unstable functions.
It does this by handling that input
()as theUnitconstructor.If we ever want to remove the Unit constructor, we could move the return type to the list of argument types, to make sure it always has at least one value.
This would also make parsing it more similar to other datatypes.
For now I just kept it the same to make the change minimal.