Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no dot in domain part say that email is valid #32

Closed
boobooking opened this issue Nov 1, 2014 · 5 comments
Closed

If no dot in domain part say that email is valid #32

boobooking opened this issue Nov 1, 2014 · 5 comments
Labels

Comments

@boobooking
Copy link

I'm trying to validate that email "boobooin@mailru" it get a valid response. But it's not.

Correct email consist dot - "boobooin@mail.ru"

Tried with CheckDNS and Strict enabled - same result.

Tried email with no existed domain "boobooin@rentzilla12.ru" with CheckDNS enabled. Same incorrect result.

What am i doing wrong? Thanks in advance!

@egulias
Copy link
Owner

egulias commented Nov 2, 2014

boobooin@mailru is a valid email address, is a top level domain address (http://tools.ietf.org/html/rfc5321#section-2.3.5)
So the validation will pass.
Now, with checkDNS and strict, should have thrown an error. I'll check it, thanks!

@egulias egulias added the bug label Nov 2, 2014
egulias added a commit that referenced this issue Nov 2, 2014
#32 - Fixed usage of DNS check and strict parameter
@egulias
Copy link
Owner

egulias commented Nov 2, 2014

Hi @boobooking please check version 1.2.4, should fix your problem.

@boobooking
Copy link
Author

Hi @egulias now it works much better! Thanks for fix.

Trying to check boobooin@rentzilla12.ru

There is no such a domain rentzilla12.ru, so i suppose that if i enable checkDNS validation will fail. But it's not.

Only if i enable strict mode validation fail.

Why that kind of checking depends on strict mode?

@egulias
Copy link
Owner

egulias commented Nov 3, 2014

If you check the release notes you'll see the reason.
The DNS check only adds warnings. If you want an email with no DNS to fail
you have to use strict=true as well.
El 03/11/2014 00:43, "boobooking" notifications@github.com escribió:

Hi @egulias https://github.com/egulias now it works much better! Thanks
for fix.

Trying to check boobooin@rentzilla12.ru

There is no such a domain rentzilla12.ru, so i suppose that if i enable
checkDNS validation will fail. But it's not.

Only if i enable strict mode validation fail.

Why that kind of checking depends on strict mode?


Reply to this email directly or view it on GitHub
#32 (comment)
.

@boobooking
Copy link
Author

Sorry! Didn't check release notes - just silently updated via composer.

Thanks for support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants