Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Update .gitignore #225

Merged
merged 1 commit into from
Jan 5, 2020
Merged

[2.1] Update .gitignore #225

merged 1 commit into from
Jan 5, 2020

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@egulias
Copy link
Owner

egulias commented Jan 2, 2020

Hi Graham,
could removing the .lock file generate inconsitencies when running tests or using the lib?

@GrahamCampbell
Copy link
Contributor Author

GrahamCampbell commented Jan 2, 2020

Composer totally ignores the lock file in this repo when you install the package as a dependency, and the tests should always work on the newest dependencies, so there's no point in having the lock file (also, the lock file is already deleted from the repo anyway).

@egulias egulias merged commit 3d09cd0 into egulias:master Jan 5, 2020
@GrahamCampbell GrahamCampbell deleted the patch-1 branch January 5, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants