[WIP] Initial start to the remove port definition work

[robtec]

Started looking at https://github.com/shipyard/shipyard/issues/373

Will keep the PR up to date with changes :)

[ehazlett]

Awesome thanks!

[robtec]

@ehazlett @tombee Just some changes to the addition of a port definition and how its displayed, its still a WIP as the UI stuff doesn't work with the backend yet. Just looking for feedback on the overall look 😄

[ehazlett]

@robtec do you have screenshots or anything for a quick view?

[robtec]

@ehazlett First image is defining a port definition

The second one is a look at how the definitions could be added to a table, easily deleted too

What's your thoughts?

[tombee]

I think it'd be cool to just add another row of <input>s each time the 'add' button is pressed.. rather than adding a table below, what do you think? It might be more compact that way too.

Also, could the 'Add' button be inline with the row of <input>s? Could perhaps swap it out for an ui button icon that has a + icon?

The 'added' rows would then have an x icon in-line, instead of the + on the add row at the top.

Binding inputs would also allow for the user to modify the port definitions after they have been added, in the case that they make a mistake or something.

[robtec]

Yeah sounds good, I was wondering about editing the table but yeah adding input rows sounds better :)

[ehazlett]

Yeah I think having the inline inputs with just the ability to remove would be nice. I'm not a fan of the table. :) Thanks!

[robtec]

Cool, I'll scrap the table, cheers for the feedback :)

[robtec]

@ehazlett should we write this off as its addressed in V3?

[ehazlett]

Yes thanks!

[ehazlett]

Thanks for the contribution. This is now part of the new v3 ui. Thanks!

[robtec]

👍 cheers @ehazlett