Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

LDAP BaseDN improvements #735

Merged
merged 5 commits into from
Mar 14, 2016
Merged

LDAP BaseDN improvements #735

merged 5 commits into from
Mar 14, 2016

Conversation

meister
Copy link
Contributor

@meister meister commented Jan 27, 2016

Disregard branch name, originally idea was a bit different..

Default behaviour is exactly the same as before, however --ldap-base-dn parameter now supports placeholder {username}. If the placeholder is found, the whole --ldap-base-dn is used as a DN.

Addresses issue https://github.com/shipyard/shipyard/issues/695

@ehazlett
Copy link
Owner

Since this can be anything perhaps it would be better as {baseDN} or something?

@meister
Copy link
Contributor Author

meister commented Jan 29, 2016

The idea is that the placeholder is for the username variable that is used for authentication.
So for example: A user by the username martin logs in.

  • When configured with --ldap-base-dn="cn=users,cn=accounts,dc=company" would produce LDAP dn cn=martin,cn=users,cn=accounts,dc=company
  • When configured as --ldap-base-dn="uid={username},cn=users,cn=accounts,dc=company" would produce LDAP dn uid=martin,cn=users,cn=accounts,dc=company. {username} being the direct replacement from the login form (and variable used inside the method as well).

@ehazlett
Copy link
Owner

Hey sorry for the delay -- this needs a rebase. Thanks!

@meister
Copy link
Contributor Author

meister commented Mar 7, 2016

Branch should be now up to date with master. Removed excess files that were added previously.

@ehazlett
Copy link
Owner

lgtm

ehazlett added a commit that referenced this pull request Mar 14, 2016
@ehazlett ehazlett merged commit 01168ee into ehazlett:master Mar 14, 2016
cncodog added a commit to dockerclubgroup/shipyard that referenced this pull request Mar 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants