Adding support to set arbitrary CacheManager and/or configuration file #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljacomet
reviewed
Sep 29, 2016
| import java.net.URL; | ||
|
|
||
| /** | ||
| * Shiro {@link CacheManager} implementation using the Ehcache 3.0 framework for all cache functionality |
There was a problem hiding this comment.
Would use 3.x here instead of 3.0 especially as prop replacement will end up requiring 3.2
|
Looks good. Question though: did you figure out how to inject a custom config file from Shiro configuration? |
|
According to this - http://shiro.apache.org/configuration.html - it should be cacheManager.cacheManagerConfigFile=file:/some/path/conf.xml |
ljacomet
reviewed
Sep 29, 2016
|
|
||
| = Resources | ||
| Official Shiro documentation on http://shiro.apache.org/configuration.html[Configuration] and http://shiro.apache.org/session-management.html[Session Management] |
There was a problem hiding this comment.
I would link to the caching documentation as well
This was referenced Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.