Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk errors handling #72

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Disk errors handling #72

merged 1 commit into from
Apr 16, 2022

Conversation

PMazarovich
Copy link
Contributor

Once after IO error worker was killed and all events just began to accumulate endlessly.
That is why it is better to handle disk errors to keep worker alive.

eht16
eht16 reviewed Apr 10, 2022
View reviewed changes
logstash_async/database.py Outdated Show resolved Hide resolved
eht16
eht16 requested changes Apr 10, 2022
View reviewed changes
Copy link
Owner

@eht16 eht16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

I have just a couple of minor comments.
And could you have a look at the code style, basically PEP8 + 100 charcters line length (see the failed CI for details) or test locally by running tox.

Thanks!

@PMazarovich
Copy link
Contributor Author

@eht16 requested changes are in place

@PMazarovich PMazarovich requested a review from eht16 April 13, 2022 09:13
@eht16 eht16 merged commit 7aaef7c into eht16:master Apr 16, 2022
@PMazarovich PMazarovich mentioned this pull request Apr 18, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eht16 eht16 Awaiting requested review from eht16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PMazarovich @eht16