Association between Reco Cluster and ReconstructedParticle #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for use in Track Matching
sly2j
requested changes
Feb 28, 2024
Comment on lines
+495
to
+505
|
|
||
| edm4eic::TrackClusterMatch: | ||
| Description: "Association between a Cluster and a ReconstructedParticle" | ||
| Author : "D. Brandenburg" | ||
| Members: | ||
| - uint32_t cluID // Index of corresponding cluster (position in cluster array) | ||
| - uint32_t plcID // Index of corresponding ReconstructedParticle (position in reco particle array) | ||
| - float weight // weight of this association | ||
| OneToOneRelations: | ||
| - edm4eic::Cluster clu // reference to the cluster | ||
| - edm4eic::ReconstructedParticle plc // reference to the Reco particle |
There was a problem hiding this comment.
I'd like to see the following changes to move forward:
- rename clu --> cluster (
clusterID,cluster), which is in-line with how we call relations to clusters in the rest of the data model - rename plc --> track ('trackID
,track`) - add a new entry commented-out entry below trackID that reads:
# - int32_t trackID. // Index of the corresponding Track (position in the track particle array), and a similar line in the OneToOneRelations - Add to the comments for the
ReconstructedParticleassociation something to the extend that this is a placeholder and will be removed in favor of a link to Track once the reconstruction is properly updated.
With these changes we can move forward and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Association container for edm4eic::Cluster and edm4eic::ReconstructedParticle
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?
Additional notes / comments
uint32_tIDs from Association containers.