Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Association between Reco Cluster and ReconstructedParticle #52

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Association between Reco Cluster and ReconstructedParticle #52

merged 11 commits into from
Oct 16, 2024

Conversation

jdbrice
Copy link
Contributor

@jdbrice jdbrice commented Sep 28, 2023 •
edited
Loading

Briefly, what does this PR introduce?

Association container for edm4eic::Cluster and edm4eic::ReconstructedParticle

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators - plan to present at SC meeting on Oct 4th

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Additional notes / comments

  • This assumes the change proposed and currently discussed by @veprbl to remove uint32_t IDs from Association containers.

@jdbrice jdbrice requested a review from a team as a code owner September 28, 2023 02:02
sly2j
sly2j previously requested changes Feb 28, 2024
View reviewed changes
edm4eic.yaml Outdated Show resolved Hide resolved
@tlprotzman tlprotzman mentioned this pull request Mar 26, 2024
Open
@veprbl veprbl requested review from a team and ruse-traveler October 8, 2024 22:48
Chao1009
Chao1009 previously approved these changes Oct 8, 2024
View reviewed changes
@Chao1009
Copy link

Chao1009 commented Oct 8, 2024 •
edited
Loading

Looks good to me!
Weight (and other possible members) can be added in the following PRs if necessary.

ruse-traveler
ruse-traveler previously approved these changes Oct 9, 2024
View reviewed changes
Copy link

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! While I am fine with this as-is, I do think that it couldn't hurt to leave the weight in. Even if we don't use it in the initial implementation, it will definitely be useful in the future ...

@veprbl veprbl dismissed stale reviews from ruse-traveler and Chao1009 via dfd6ce4 October 10, 2024 23:19
ruse-traveler
ruse-traveler approved these changes Oct 15, 2024
View reviewed changes
Copy link

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

@veprbl veprbl enabled auto-merge (squash) October 16, 2024 17:13
@veprbl veprbl merged commit 33e68e6 into eic:main Oct 16, 2024
3 of 4 checks passed
This was referenced Oct 28, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@ruse-traveler ruse-traveler ruse-traveler approved these changes

@sly2j sly2j sly2j left review comments

@Chao1009 Chao1009 Chao1009 left review comments

Assignees

@jdbrice jdbrice

@tlprotzman tlprotzman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jdbrice @Chao1009 @veprbl @sly2j @ruse-traveler @tlprotzman