fix: add EDM4hep include dir #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue when EDM4hep is installed in a dedicated prefix and the include directory does not end up in the compilation include line by virtue of other includes (as is the case when everything is in /usr/local).
|
See also discussion at eic/eicd#6. |
veprbl
approved these changes
Sep 4, 2022
7 tasks
wdconinc
added a commit
that referenced
this pull request
Sep 20, 2022
### Briefly, what does this PR introduce? This removes the `target_include_directories` introduced in #6 again, since the `target_link_libraries` introduced in #5 set the include directories the right way. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [X] Other: technical debt reduction ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue when EDM4hep is installed in a dedicated prefix and the include directory does not end up in the compilation include line by virtue of other includes (as is the case when everything is in /usr/local).
Briefly, what does this PR introduce?
New include directory in the top level CMakeLists.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes, in that it makes the default compilation succeed on some systems where it previously didn't.