Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalorimeterClusterRecoCoG: copy hits references from ProtoCluster #1224

Merged
merged 3 commits into from
Jan 13, 2024
Merged

CalorimeterClusterRecoCoG: copy hits references from ProtoCluster #1224

merged 3 commits into from
Jan 13, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 13, 2024

Briefly, what does this PR introduce?

Resolves: #1223

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@github-actions github-actions bot added the topic: calorimetry relates to calorimetry label Jan 13, 2024
@github-actions GitHub Actions
Copy link

Capybara summary for PR 1224

@wdconinc wdconinc mentioned this pull request Jan 13, 2024
Open
wdconinc
wdconinc approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs only in hits and hitContributions.

@ruse-traveler
Copy link
Contributor

🙌 Very nice!! 🙌

@veprbl veprbl added this pull request to the merge queue Jan 13, 2024
Merged via the queue into main with commit df88afc Jan 13, 2024
66 of 75 checks passed
@veprbl veprbl deleted the pr/cluster_hits branch January 13, 2024 20:00
@veprbl veprbl mentioned this pull request Jan 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2024
@veprbl
femc_studies,lfhcal_studies: remove broken code (#1226)
18b7de8 
Fixes regression introduced by #1224

It would appear those loops were never utilized before. There are
simular loops for the inlined "kMA" clustering code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc wdconinc approved these changes

@ruse-traveler ruse-traveler ruse-traveler approved these changes

Assignees
No one assigned
Labels
topic: calorimetry relates to calorimetry
Projects
ePIC Software and Computing
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Calorimeter Cluster-Hit Associations in PODIO Output
3 participants
@veprbl @ruse-traveler @wdconinc