-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): trigger eicweb container build for benchmarks #471
Conversation
Well, that worked better than I thought it was going to: container build triggered, but with standard eicrecon. |
ce9100b
to
35d8387
Compare
35d8387
to
daa4381
Compare
Triggered correctly at https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/2018552#L278 |
3c4f76a
to
b1d8671
Compare
b1d8671
to
68bc86a
Compare
68bc86a
to
432d00d
Compare
432d00d
to
a4b5aa3
Compare
a4b5aa3
to
0eedac5
Compare
0eedac5
to
6c006a4
Compare
@veprbl This now works, and the last CI run through was successful through running the pipelines after building the temporary container, with the exception that it pushed that temporary container to a docker hub eicweb/jug_xl:eicrecon--default where there should have been a hash between the two dashes... i.e. https://hub.docker.com/layers/eicweb/jug_dev/eicrecon--default/images/sha256-7446018a5c52b4b1982ced5ec437eb240862988334a59037f257c45a7e7051ce?context=explore |
This now works and should be ready for review and merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'm wondering, if we'd need to propagate GitHub PR info from container pipelines to downstream pipelines somehow. |
That used to be the case and it used to work. But changes in the way the benchmarks were reconfigured (https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/merge_requests/150) introduced circular dependencies that broke propagation (https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/merge_requests/154, https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/736). So temporarily we don't have direct status callbacks from downstream benchmarks and only get the container status callback after the benchmark pipelines complete. I think that is probably ok for now. |
Briefly, what does this PR introduce?
After some initial succesful running of eicrecon, we pass on to building a full eicweb container and subsequent benchmarks.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No. Won't make this test required (for now) so shouldn't slow down the pipelines until completion.