Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): trigger eicweb container build for benchmarks #471

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Feb 8, 2023

Briefly, what does this PR introduce?

After some initial succesful running of eicrecon, we pass on to building a full eicweb container and subsequent benchmarks.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators @sly2j

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No. Won't make this test required (for now) so shouldn't slow down the pipelines until completion.

@wdconinc
Copy link
Contributor Author

wdconinc commented Feb 8, 2023

Well, that worked better than I thought it was going to: container build triggered, but with standard eicrecon.

@wdconinc wdconinc temporarily deployed to github-pages October 7, 2023 01:31 — with GitHub Actions Inactive
@wdconinc
Copy link
Contributor Author

wdconinc commented Oct 7, 2023

@wdconinc wdconinc temporarily deployed to github-pages October 7, 2023 15:04 — with GitHub Actions Inactive
@wdconinc
Copy link
Contributor Author

wdconinc commented Oct 9, 2023

@wdconinc
Copy link
Contributor Author

Seems to be working: eic_container triggered, which triggered detector benchmarks, which triggered both reconstruction and physics benchmarks. All are running so no final success or failure yet.

Screenshot_20231009-223341

@wdconinc wdconinc temporarily deployed to github-pages October 26, 2023 20:59 — with GitHub Actions Inactive
@wdconinc wdconinc temporarily deployed to github-pages October 27, 2023 05:41 — with GitHub Actions Inactive
@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 8, 2024

@veprbl This now works, and the last CI run through was successful through running the pipelines after building the temporary container, with the exception that it pushed that temporary container to a docker hub eicweb/jug_xl:eicrecon--default where there should have been a hash between the two dashes... i.e. https://hub.docker.com/layers/eicweb/jug_dev/eicrecon--default/images/sha256-7446018a5c52b4b1982ced5ec437eb240862988334a59037f257c45a7e7051ce?context=explore

@wdconinc
Copy link
Contributor Author

This now works and should be ready for review and merging.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wdconinc wdconinc added this pull request to the merge queue Jan 12, 2024
@veprbl
Copy link
Member

veprbl commented Jan 12, 2024

I'm wondering, if we'd need to propagate GitHub PR info from container pipelines to downstream pipelines somehow.

@wdconinc
Copy link
Contributor Author

That used to be the case and it used to work. But changes in the way the benchmarks were reconfigured (https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/merge_requests/150) introduced circular dependencies that broke propagation (https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/merge_requests/154, https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/736). So temporarily we don't have direct status callbacks from downstream benchmarks and only get the container status callback after the benchmark pipelines complete. I think that is probably ok for now.

Merged via the queue into main with commit d312935 Jan 12, 2024
75 checks passed
@wdconinc wdconinc deleted the trigger-eicweb-container branch January 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants