Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): no cancel-in-progress on main #939

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Sep 9, 2023

Briefly, what does this PR introduce?

This will prevent main pipelines from being interrupted by newer merges. This is becoming relevant in times of frequent merges. Because we do one or two extra things on main (like not just running clang-tidy on diffs only), the merge queue will complete faster than the previous main pipeline, so we risk just canceling every main pipeline...

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc marked this pull request as ready for review September 9, 2023 16:42
@wdconinc wdconinc requested a review from veprbl September 9, 2023 16:43
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@wdconinc wdconinc added this pull request to the merge queue Sep 9, 2023
Merged via the queue into main with commit 3c54522 Sep 9, 2023
86 checks passed
@wdconinc wdconinc deleted the no-cancel-in-progress-on-main branch September 9, 2023 18:14
@wdconinc wdconinc temporarily deployed to github-pages September 9, 2023 19:45 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants