feat: enable ubsan by default in CI, with print_stacktrace=1 and suppressions #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
One more spurious ubsan stack trace at https://github.com/eic/EICrecon/actions/runs/6224924646/job/16895351952?pr=987#step:5:608 |
wdconinc
force-pushed
the
enable-ubsan
branch
from
fcbf348
to
f4aa0e1
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
force-pushed
the
enable-ubsan
branch
from
f4aa0e1
to
d83be6d
Compare
wdconinc
force-pushed
the
enable-ubsan
branch
from
d83be6d
to
9cbaf25
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
force-pushed
the
enable-ubsan
branch
from
9cbaf25
to
96c7396
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
force-pushed
the
enable-ubsan
branch
from
96c7396
to
fb6ce02
Compare
veprbl
approved these changes
Oct 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables ubsan by default in CI, with some more undefined behaviors (float-divide-by-zero, unsigned-integer-overflow, local-bounds). It has two suppressions already, but more will no doubt be needed to limit the output to what we control. There is no way to have an exitcode != 0 when undefined behavior is found, so this depends a bit on people checking the output periodically.
TODO: