feat: generate eicrecon
commands with a YAML file
#65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Use a
yaml
configuration file to set configuration parameters for EICrecon.The hard-coded parameters in
recon.sh
are moved to configuration files inconfig/
. Use the new scriptrecon.rb
together with one of theseyaml
files to run EICrecon. Deprecated Juggler support inrecon.sh
is moved to a new wrapper script,juggler.sh
(recon.sh
has been renamed tojuggler.sh
, and its EICrecon support has been removed).This allows us to (a) run with parameters on the EICrecon IRT development branch
irt-algo
orirt-algo-stable
, (b) run with parameters for EICreconmain
, or (c) run with any other set of custom parameters.This also serves as a proof of concept for configuration file parsing, where the configuration structure is tree-like:
yaml
fileconfig/recon_sandbox.yaml
eicrecon
commandyaml
ineicrecon
(see configuration file for parameters EICrecon#346)DDParsers
EICrecon#390Example output of
recon.rb -c config/recon_sandbox.yaml
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
yes:
@chchatte92 and @DelloStritto: use
recon.rb
instead ofrecon.sh
: