-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build fails outside of eic-shell #8
Comments
Hm... This works for me except I had to update to cmake 3.24 |
Right. I'm also using that, but that was not the issue. It is that the edm4hep include directory is not found. |
In case it is useful, here it the full output of my cmake command:
|
I can reproduce |
Actually, this should have been fixed in #6. @faustus123 Can you try on master? |
Works here. I took liberty to tag v1.0.1 that includes the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment: (where does this bug occur, have you tried other environments)
main
for latest released): v1.0.0HEAD
for the most recent on git):Steps to reproduce: (give a step by step account of how to trigger the bug)
This is done outside of eic-shell
Expected Result: (what do you expect when you execute the steps above)
Package builds
Actual Result: (what do you get when you execute the steps above)
The build fails with the message below indicating it is unable to find the edm4hep/Vector3f.h file. Messages during the cmake stage indicate it is finding the correct podio and edm4hep versions. I also confirmed that the the file exists in the edm4hep build.
I suspect this is due to development and testing being done entirely within eic-shell which has edm4hep include files installed (symlinked) in /usr/local which is in the include path by default. Building in an environment where edm4hep is installed outside of common directories like /usr/local will need to have the edm4hep include directory added.
[ 1%] Building CXX object CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o
/opt/rh/devtoolset-9/root/usr/bin/c++ -Dedm4eic_EXPORTS -I/home/davidl/work/2022.07.11.EICrecon/EICTOP/root/root-6.26.04/include -I/home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build -isystem /home/davidl/work/2022.07.11.EICrecon/EICTOP/PODIO/v00-15/install/include -std=c++17 -pipe -fsigned-char -pthread -fPIC -std=gnu++2a -MD -MT CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o -MF CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o.d -o CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o -c /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/src/ReconstructedParticle.cc
In file included from /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/edm4eic/ReconstructedParticleObj.h:7,
from /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/edm4eic/ReconstructedParticle.h:6,
from /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/src/ReconstructedParticle.cc:4:
/home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/edm4eic/ReconstructedParticleData.h:7:10: fatal error: edm4hep/Vector3f.h: No such file or directory
7 | #include "edm4hep/Vector3f.h"
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
The text was updated successfully, but these errors were encountered: