Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails outside of eic-shell #8

Closed
faustus123 opened this issue Sep 7, 2022 · 6 comments
Closed

build fails outside of eic-shell #8

faustus123 opened this issue Sep 7, 2022 · 6 comments
Assignees

Comments

@faustus123
Copy link

Environment: (where does this bug occur, have you tried other environments)

  • Which branch (often main for latest released): v1.0.0
  • Which version (or HEAD for the most recent on git):
  • Any specific OS or system where the issue occurs? RHEL7
  • Any special versions of ROOT or Geant4?

Steps to reproduce: (give a step by step account of how to trigger the bug)

This is done outside of eic-shell

  1. cmake build against PODIO v00-15 and edm4hep v00-06

Expected Result: (what do you expect when you execute the steps above)

Package builds

Actual Result: (what do you get when you execute the steps above)

The build fails with the message below indicating it is unable to find the edm4hep/Vector3f.h file. Messages during the cmake stage indicate it is finding the correct podio and edm4hep versions. I also confirmed that the the file exists in the edm4hep build.

I suspect this is due to development and testing being done entirely within eic-shell which has edm4hep include files installed (symlinked) in /usr/local which is in the include path by default. Building in an environment where edm4hep is installed outside of common directories like /usr/local will need to have the edm4hep include directory added.

[ 1%] Building CXX object CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o
/opt/rh/devtoolset-9/root/usr/bin/c++ -Dedm4eic_EXPORTS -I/home/davidl/work/2022.07.11.EICrecon/EICTOP/root/root-6.26.04/include -I/home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build -isystem /home/davidl/work/2022.07.11.EICrecon/EICTOP/PODIO/v00-15/install/include -std=c++17 -pipe -fsigned-char -pthread -fPIC -std=gnu++2a -MD -MT CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o -MF CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o.d -o CMakeFiles/edm4eic.dir/src/ReconstructedParticle.cc.o -c /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/src/ReconstructedParticle.cc
In file included from /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/edm4eic/ReconstructedParticleObj.h:7,
from /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/edm4eic/ReconstructedParticle.h:6,
from /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/src/ReconstructedParticle.cc:4:
/home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/edm4eic/ReconstructedParticleData.h:7:10: fatal error: edm4hep/Vector3f.h: No such file or directory
7 | #include "edm4hep/Vector3f.h"
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

@DraTeots
Copy link

DraTeots commented Sep 7, 2022

Hm... This works for me except I had to update to cmake 3.24

@faustus123
Copy link
Author

Right. I'm also using that, but that was not the issue. It is that the edm4hep include directory is not found.

@faustus123
Copy link
Author

In case it is useful, here it the full output of my cmake command:

(venv) bash-4.2$ cmake -S . -B build -DCMAKE_INSTALL_PREFIX=${EDM4EIC_ROOT} -DCMAKE_CXX_STANDARD=17
-- The CXX compiler identification is GNU 9.3.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/rh/devtoolset-9/root/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Python: /home/davidl/work/2022.07.11.EICrecon/EICTOP/python/virtual_environments/venv/bin/python3 (found version "3.8.13") found components: Interpreter 
-- Found podio: /home/davidl/work/2022.07.11.EICrecon/EICTOP/PODIO/v00-15/install/lib64/cmake/podio/podioConfig.cmake (Required is at least version "0.15") 
-- Found podio: /home/davidl/work/2022.07.11.EICrecon/EICTOP/PODIO/v00-15/install/lib64/cmake/podio/podioConfig.cmake  
-- Found EDM4HEP: /home/davidl/work/2022.07.11.EICrecon/EICTOP/EDM4hep/v00-06/install/lib64/cmake/EDM4HEP/EDM4HEPConfig.cmake (Required is at least version "0.4.1") 
-- Could not find clang-format executable!
-- Could not find .clang-format file!
-- Skip formatting of generated code files.
-- Creating 'edm4eic' datamodel

                                                  
                                                    PODIO Data Model
                                                    ================
                                                    Used
                                                      edm4eic.yaml
                                                    to create
                                                      105 classes
                                                    in
                                                      /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build/
                                                    Read instructions in
                                                    the README.md to run
                                                    your first example!
                                                  
                                                  
                                                  
                                                  
                                                  
                                                  
                                                  
                                                  

     'Homage to the Square' - Josef Albers


-- Found Doxygen: /usr/bin/doxygen (found version "1.8.5") found components: doxygen dot 
-- Configuring done
-- Generating done
-- Build files have been written to: /home/davidl/work/2022.07.11.EICrecon/EICTOP/edm4eic/v1.0.0/build

@veprbl
Copy link
Member

veprbl commented Sep 7, 2022

I can reproduce

@veprbl veprbl self-assigned this Sep 7, 2022
@veprbl
Copy link
Member

veprbl commented Sep 8, 2022

Actually, this should have been fixed in #6. @faustus123 Can you try on master?

@veprbl
Copy link
Member

veprbl commented Sep 8, 2022

Works here. I took liberty to tag v1.0.1 that includes the fix.

@veprbl veprbl closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants