fix: add EcalBarrel vars to template; EcalBarrel_rmin:=81cm; EcalBarrel_thickness:=35cm #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
changed the title
|
@Chao1009 Increasing the radius doesn't cause any issues with overlaps in my local tests (tgeo only). The tracking region parametrization will likely need to change, so I use an rmin = max(81cm, determined radius) to make sure we are at 81cm but if the tracking region gets larger than that we still expand outwards. |
Chao1009
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Looks good to me.
The failed overlap check seems to be caused by BarrelCalorimeterSciGlass. It is an issue with outdated configurations, not the parameters, but we have to fix that (#579) before this merge, otherwise, it will fail all the PR checks.
Chao1009
force-pushed
the
ecal-barrel-template-vars
branch
from
9b30d8e
to
acc044b
Compare
wdconinc
force-pushed
the
ecal-barrel-template-vars
branch
from
acc044b
to
d277b48
Compare
Rebased after that PR was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This adds a number of EcalBarrel variables to the detector parameter table template.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.