Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-eic-shell.yml: trigger {physics,reconstruction}_benchmarks directly #737

Merged
merged 2 commits into from
May 24, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 24, 2024

Trigger physics benchmarks directly. After eic/detector_benchmarks#23, the downstream pipelines are not triggered, so we need to trigger them ourselves. This is a good opportunity start to triggering them earlier.

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

Trigger physics benchmarks directly. After eic/detector_benchmarks#23, the downstream pipelines are not triggered, so we need to trigger them ourselves. This is a good opportunity start to triggering them earlier.
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label May 24, 2024
@veprbl veprbl changed the title linux-eic-shell.yml: trigger physics_benchmarks directly linux-eic-shell.yml: trigger {physics,reconstruction}_benchmarks directly May 24, 2024
@veprbl veprbl mentioned this pull request May 24, 2024
7 tasks
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should make sure to update the required tests since I don't think they include the detector benchmarks now.

@veprbl veprbl enabled auto-merge May 24, 2024 20:00
@veprbl veprbl added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit f638ae9 May 24, 2024
111 checks passed
@veprbl veprbl deleted the pr/trigger_physics_benchmarks branch May 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants