Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for discrete variables in Hamiltonian Monte Carlo sampler #79

Closed
zoj613 opened this issue Jul 9, 2020 · 1 comment
Closed

Comments

@zoj613
Copy link

zoj613 commented Jul 9, 2020

Ive read in the documentation that this library only supports continuous variables. Any thoughts on adding support for loglikelihood functions that have a mixture of continuous and discrete parameters? The following papers seem to be addressing how to build a sampler in such a case:
Discontinuous Hamiltonian Monte Carlo for discrete parameters and discontinuous likelihoods

Continuous Relaxations for DiscreteHamiltonian Monte Carlo

Auxiliary-variable Exact Hamiltonian MonteCarlo Samplers for Binary Distributions

@zoj613 zoj613 changed the title Support for discrete variables in Hamiltonain Monte Carlo sampler Support for discrete variables in Hamiltonian Monte Carlo sampler Jul 9, 2020
@eigenfoo
Copy link
Owner

eigenfoo commented Jul 10, 2020

Hi!

I view discrete variables as outside the scope of this project. Users who want to sample discrete parameters should consider using PyMC3 instead which already supports a bunch of discrete random variables. This project is limited to merely exposing the vanilla HMC/NUTS sampler (that was already in PyMC3) for use with an arbitrary Python callable as a logp/dlogp function.

Apologies if this wasn't clear in the README: I've written this up in the littlemcmc docs, but I should definitely point to that in the README. I'll close this issue now, but thanks for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants