Refactor to use new common packages + remove eik map command #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the map command has been removed in favour of a single publish command
it should only use the configuration version to avoid version mismatch
Co-authored-by: Richard Walker <digitalsadhu@gmail.com>
trygve-lie
reviewed
Aug 16, 2022
classes/integrity.js
Outdated
|
|
||
| const { ValidationError } = schemas; |
There was a problem hiding this comment.
A little bit of consistency nit picking here, but I find the deconstruction here a little bit inconsistent.
This means that some places we are doing ex so:
schemas.assert.version(this.version);
and other places so:
throw new ValidationError(`Parameter "debug" is not valid`);
I would prefer that we either deconstructed both so we do as follow:
assert.version(this.version);
throw new ValidationError(`Parameter "debug" is not valid`);
or non so we do as follow:
schemas.assert.version(this.version);
throw new schemas.ValidationError(`Parameter "debug" is not valid`);
trygve-lie
approved these changes
Aug 16, 2022
|
🎉 This PR is included in version 3.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the previous
eik mapcommand intoeik publish, as well as moving over to the new separated common packages.