Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolling issue #19

Closed
eikek opened this issue Sep 20, 2018 · 0 comments
Closed

Fix scrolling issue #19

eikek opened this issue Sep 20, 2018 · 0 comments
Labels
bug Something isn't working player Changes mpc4s-player component
Milestone
0.3.0

Comments

@eikek
Copy link
Owner

eikek commented Sep 20, 2018

When coming back from album detail to album list, the page should scroll to the corresponding album.
@eikek eikek added bug Something isn't working player Changes mpc4s-player component labels Sep 20, 2018
@eikek eikek added this to the 0.3.0 milestone Sep 20, 2018
eikek added a commit that referenced this issue Sep 20, 2018
@eikek
Player: Scroll to current album when coming from album detail
43ca436 
When going back (back button) from album detail page, the album list
page is scrolled to the album that was just shown.

Issue: #19
@eikek eikek closed this as completed Sep 20, 2018
eikek added a commit that referenced this issue Sep 22, 2018
@eikek
Player: Replace aweful slow makeId function with Base64.encode
43a37fd 
It's not only faster, but also allows to use the complete name of the
album. The performance was noticeably degraded on low power devices,
like my cheap 7 inch tablet.

Issue: #19
eikek added a commit that referenced this issue Sep 22, 2018
@eikek
Player: Replace aweful slow makeId function with Base64.encode
36d47db 
It's not only faster, but also allows to use the complete name of the
album. The performance was noticeably degraded on low power devices,
like my cheap 7 inch tablet.

Issue: #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working player Changes mpc4s-player component
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@eikek