Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): introduce v1beta1 API #65

Merged
merged 2 commits into from
Nov 9, 2022
Merged

feat(auth): introduce v1beta1 API #65

merged 2 commits into from
Nov 9, 2022

Conversation

radhus
Copy link
Member

@radhus radhus commented Nov 4, 2022

Changes from v1alpha2:

  • Now uses Client ID instead of a user reference, to simplify as well as aligning with standards and user interface.

  • Prefix fields with client_ for clarity, i.e. client_id and client_secret,

@radhus radhus force-pushed the auth-v1beta1 branch 2 times, most recently from 284285f to 298af55 Compare November 7, 2022 07:56
@radhus radhus marked this pull request as ready for review November 7, 2022 12:32
Copy link
Member

@odsod odsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

openapiv2/auth.swagger.yaml Show resolved Hide resolved
Changes from v1alpha2:

* Now uses Client ID instead of a user reference, to simplify as well as
  aligning with standards and user interface.

* Prefix fields with `client_` for clarity, i.e. `client_id` and
  `client_secret`, and to align with OAuth2 terms and UI labels.

* Mark `client_secret` as sensitive using einride/sensitive annotations.
@radhus radhus merged commit 4ee7534 into master Nov 9, 2022
@radhus radhus deleted the auth-v1beta1 branch November 9, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants