Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link issue #18

Closed
sickness0666 opened this issue Jun 5, 2015 · 8 comments
Closed

link issue #18

sickness0666 opened this issue Jun 5, 2015 · 8 comments

Comments

@sickness0666
Copy link

http://www.crunchyroll.com/gintama/episode-269-forget-dates-remember-people-you-can-hide-your-porn-mags-but-you-cant-hide-your-678771

im guessing the issue is related to the *** in title name that cannot be used in windows file names

@einstein95
Copy link
Owner

Why does Gintama hate me ;_;
(will fix soon)

@sickness0666
Copy link
Author

ahahaha, ya i know. i only had a couple issues, one was with the *** in a couple ep names, other was from EXTREMLY long names, which you had fixed, so i got the most recent update. ive had issues sometimes with some other eps of shows with ' in the title when processing, instead of &quote, but i just changed the ultimate.py to replace ' and &quote with nothing

@sickness0666
Copy link
Author

another issue link is:
http://www.crunchyroll.com/gintama/episode-11-look-overly-sticky-sweet-dumplings-are-not-real-dumplings-you-idiot-510056

issue is with the comma in the title name, stripping out the comma in ultimate.py fixes the issue

einstein95 added a commit that referenced this issue Jun 6, 2015
…ring replacement, looks a lot more cleaner.
@einstein95
Copy link
Owner

Hmm... No issues with commas in titles. Could you give a URL whre you "had
issues sometimes with some other eps of shows with ' in the title when
processing, instead of "e;"?

On Sat, Jun 6, 2015 at 2:39 PM Jeremy notifications@github.com wrote:

another issue link is:

http://www.crunchyroll.com/gintama/episode-11-look-overly-sticky-sweet-dumplings-are-not-real-dumplings-you-idiot-510056

issue is with the comma in the title name, stripping out the comma in
ultimate.py fixes the issue


Reply to this email directly or view it on GitHub
#18 (comment)
.

@sickness0666
Copy link
Author

i believe it was with a couple of episodes in hunter x hunter, they would error out when processing through the mkv merge i believe it was, i had ultimate.py just strip out the ' from the video title and had no issues since then

@sickness0666
Copy link
Author

and that "e; was supposed to be the html code &quote, but i guess the comments auto changed it lol

@Zaphain
Copy link

Zaphain commented Jun 12, 2015

http://www.crunchyroll.com/kill-la-kill/episode-1-if-only-i-had-thorns-like-a-thistle-644301
There's an issue with the ellipsis in the title

Problem with this link too:
http://www.crunchyroll.com/naruto/episode-131-the-secrets-of-the-mangeky-sharingan-520266
probably from the 'ō' in the title.

@einstein95
Copy link
Owner

Should be properly fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants