Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minkowski metric in polar coordinates #450

Closed
ritzvik opened this issue Mar 22, 2020 · 5 comments · Fixed by #455
Closed

Add minkowski metric in polar coordinates #450

ritzvik opened this issue Mar 22, 2020 · 5 comments · Fixed by #455
Labels

Comments

@ritzvik
Copy link
Member

ritzvik commented Mar 22, 2020

🐞 Problem
Currently minkowski metric is defined in cartesian coordinates. We need MinkowskiPolar.

🎯 Goal

The metric expression is diag(-1, 1, r ** 2, r ** 2 * sin(theta) ** 2). Include c(speed of light) in a similar fashion to that of given below.

💡 Possible solutions

New addition expected in the same file as given below :

def Minkowski(c=constants.c):
"""
Minkowski(flat) space-time. Space-time without any curvature or matter.
Parameters
----------
c : ~sympy.core.basic.Basic or int or float
Any value to assign to speed of light. Defaults to 'c'.
"""
coords = symbols("t x y z")
metric = diag(-1, 1 / (c ** 2), 1 / (c ** 2), 1 / (c ** 2)).tolist()
return MetricTensor(metric, coords, "ll")

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@mightomi
Copy link
Contributor

I would love to work on this issue if i can.

@ritzvik
Copy link
Member Author

ritzvik commented Mar 22, 2020 via email

@mightomi
Copy link
Contributor

mightomi commented Mar 22, 2020

Okay :)

@gravitas21
Copy link
Contributor

@ritzvik Can I work on this?

@ritzvik
Copy link
Member Author

ritzvik commented Mar 23, 2020

@ritzvik Can I work on this?

Go ahead 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants