This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zisimo
reviewed
Jun 28, 2018
app.js
Outdated
@@ -34,6 +34,16 @@ bot.recognizer(recognizer); | |||
// Configure PMKB Client. ENV variables are stored in Azure. | |||
const pmkbClient = new PMKBClient(process.env.PMKB_HOST, process.env.PMKB_USER, process.env.PMKB_PASS); | |||
|
|||
// Set up speech services | |||
const speechOptions = { | |||
speechRecognizer: new CognitiveServices.SpeechRecognizer({ subscriptionKey: 'MICROSOFT_SPEECH_API_KEY' }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MICROSOFT_SPEECH_API_KEY
Doesn't that come from environment variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I thought I changed that sorry
app.js
Outdated
speechRecognizer: new CognitiveServices.SpeechRecognizer({ subscriptionKey: 'MICROSOFT_SPEECH_API_KEY' }), | ||
speechSynthesizer: new CognitiveServices.SpeechSynthesizer({ | ||
gender: CognitiveServices.SynthesisGender.Female, | ||
subscriptionKey: 'MICROSOFT_SPEECH_API_KEY', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with the comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
zisimo
approved these changes
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.