Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/svg #29

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Feature/svg #29

merged 3 commits into from
Jan 8, 2021

Conversation

eirikb
Copy link
Owner

@eirikb eirikb commented Jan 8, 2021

No description provided.

@eirikb
Hello SVG
ee3995e 
Darn svg. Problem: SVG (AND CHILDREN!) _must_ be created using document.createElementNS.
domdom JSX return plain elements.
JSX creates children before parents.
Without link to parent a <circle> won't know it must have a namespace.
Hack: Rebuild elements. Messy.
@eirikb
On in SVG
852c2d3 
And attributes and stuff.
Renamed function to a more appropriate name.
@eirikb
6.1.0
8facbcf
@eirikb eirikb merged commit 05624b7 into master Jan 8, 2021
@eirikb eirikb deleted the feature/svg branch January 9, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eirikb