-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic bun integration #1108
Basic bun integration #1108
Conversation
I'm a bit worried about scope creep for the frontend-maven-plugin. Would it make sense to make something separate, like bun-maven-plugin? |
Maybe it could be an option, on the other hand this plugin is quite universal, it also supports yarn, so i've thought it would be a good idea to add this feature also |
...d-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/BunInstaller.java
Outdated
Show resolved
Hide resolved
...d-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/BunInstaller.java
Outdated
Show resolved
Hide resolved
@eirslett So as i understand, it's an organizational problem to integrate this because it's difficult to maintain so many technologies? Or is there something else to consider? Should this PR be closed? |
Yes it's mostly organizational. More features keep getting requested and added, but there's limited time for maintenance, bug fixes etc. But I triggered the test suite now. I suppose we can merge the bun stuff, it's a promising runtime! |
Looks like the MacOS build is failing on |
strange..maybe some github hickup, my pipeline ist green: https://github.com/deemkeen/frontend-maven-plugin/actions/runs/7047737618 maybe we could rerun it? |
It was a hiccup! |
@eirslett great, thanks! |
@deemkeen could you please have a look at updating support here, so Bun also can be used on Windows? |
@eirslett yeah sure, I'll take a look at it this weekend! |
I'm getting strange crashes, while trying to run the tests with the windows runner. Does anyone have any ideas?
Is it possible, that the windows support is still experimental? |
@deemkeen Not sure! Maybe they have ironed out the issues by now? @giverly-devops if you're able to, you could take a stab at it! (See #1146) |
Summary
Basic bun integration as requested in #1106
Bun still doesn't work with windows, so i've tried to skip the windows integration tests, maybe there is a better way to do it