Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic bun integration #1108

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Basic bun integration #1108

merged 9 commits into from
Nov 30, 2023

Conversation

deemkeen
Copy link
Contributor

Summary

Basic bun integration as requested in #1106
Bun still doesn't work with windows, so i've tried to skip the windows integration tests, maybe there is a better way to do it

@deemkeen deemkeen changed the title Feature 1106 Basic bun integration Sep 15, 2023
@deemkeen deemkeen marked this pull request as ready for review September 15, 2023 19:08
@eirslett
Copy link
Owner

I'm a bit worried about scope creep for the frontend-maven-plugin. Would it make sense to make something separate, like bun-maven-plugin?

@deemkeen
Copy link
Contributor Author

I'm a bit worried about scope creep for the frontend-maven-plugin. Would it make sense to make something separate, like bun-maven-plugin?

Maybe it could be an option, on the other hand this plugin is quite universal, it also supports yarn, so i've thought it would be a good idea to add this feature also

@deemkeen
Copy link
Contributor Author

@eirslett So as i understand, it's an organizational problem to integrate this because it's difficult to maintain so many technologies? Or is there something else to consider? Should this PR be closed?

@eirslett
Copy link
Owner

Yes it's mostly organizational. More features keep getting requested and added, but there's limited time for maintenance, bug fixes etc. But I triggered the test suite now. I suppose we can merge the bun stuff, it's a promising runtime!

@eirslett
Copy link
Owner

Looks like the MacOS build is failing on bun install for some reason...

@deemkeen
Copy link
Contributor Author

Looks like the MacOS build is failing on bun install for some reason...

strange..maybe some github hickup, my pipeline ist green:

https://github.com/deemkeen/frontend-maven-plugin/actions/runs/7047737618

maybe we could rerun it?

@eirslett eirslett merged commit ad6710f into eirslett:master Nov 30, 2023
3 checks passed
@eirslett
Copy link
Owner

It was a hiccup!

@deemkeen
Copy link
Contributor Author

@eirslett great, thanks!

@deemkeen deemkeen deleted the feature-1106 branch November 30, 2023 21:59
@eirslett
Copy link
Owner

eirslett commented Apr 2, 2024

@deemkeen could you please have a look at updating support here, so Bun also can be used on Windows?

@deemkeen
Copy link
Contributor Author

deemkeen commented Apr 3, 2024

@eirslett yeah sure, I'll take a look at it this weekend!

@deemkeen
Copy link
Contributor Author

deemkeen commented Apr 6, 2024

I'm getting strange crashes, while trying to run the tests with the windows runner. Does anyone have any ideas?

[INFO] [DEBUG] Executing command line [D:\a\frontend-maven-plugin\frontend-maven-plugin\frontend-maven-plugin\target\it\bun-integration\target\bun, install] [INFO] [INFO] [INFO] [INFO] Panic: start index is larger than end index [INFO] [INFO] [INFO] [INFO] bun has crashed :'( [INFO] [INFO] [INFO] [INFO] ----- bun meta ----- [INFO] [INFO] Bun v1.1.2 (c8d072c2) Windows x64 [INFO] [INFO] Unknown: [INFO] [INFO] Elapsed: 0ms | User: 0ms | Sys: 0ms [INFO] [INFO] RSS: 16.79MB | Peak: 16.79MB | Commit: 62.39MB | Faults: 4255 [INFO] [INFO] ----- bun meta ----- [INFO] [INFO] [INFO] [INFO] 0 00007FF74836E048 [INFO] [INFO] 1 ??? [INFO] [INFO] 2 ??? [INFO] [INFO] 3 ??? [INFO] [INFO] 4 ??? [INFO] [INFO] 5 ??? [INFO] [INFO] 6 ??? [INFO] [INFO] [INFO] [INFO] Search GitHub issues https://bun.sh/issues or join in #windows channel in https://bun.sh/discord [INFO] [INFO] [INFO] [INFO] thread 3632 panic: start index is larger than end index [INFO] [INFO] ???:?:?: 0x7ff746fae7de in ??? (bun) [INFO] [INFO] ???:?:?: 0x7ff746cd1603 in ??? (bun) [INFO] [INFO] ???:?:?: 0x7ff74986e033 in ??? (bun) [INFO] [INFO] ???:?:?: 0x7ffe38334caf in ??? (KERNEL32.DLL) [INFO] [INFO] ???:?:?: 0x7ffe3863e8aa in ??? (ntdll.dll) [INFO] [INFO] ------------------------------------------------------------------------ [INFO] [INFO] BUILD FAILURE

Is it possible, that the windows support is still experimental?

@eirslett
Copy link
Owner

@deemkeen Not sure! Maybe they have ironed out the issues by now? @giverly-devops if you're able to, you could take a stab at it! (See #1146)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants