Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid formatting in changelog #147

Merged
merged 6 commits into from
Jul 11, 2024
Merged

fix: invalid formatting in changelog #147

merged 6 commits into from
Jul 11, 2024

Conversation

ejbills
Copy link
Owner

@ejbills ejbills commented Jul 11, 2024

No description provided.

ejbills and others added 6 commits July 10, 2024 19:21
@ejbills
Update update-changelog.yml
06d84f7
@ejbills
chore: update changelog for v1.1.1
3fe6dd4 
    This commit was created by changelog-from-release in 'Update changelog on release published' CI workflow
@ejbills
Update update-changelog.yml
891b75a
@ejbills
chore: update changelog for v1.1.1
38fd639 
    This commit was created by changelog-from-release in 'Update changelog on release published' CI workflow
@ejbills
Update update-changelog.yml
fcb5449
@ejbills
chore: update changelog for v1.1.1
c2b739b 
    This commit was created by changelog-from-release in 'Update changelog on release published' CI workflow
@ejbills ejbills merged commit 50ff95d into main Jul 11, 2024
1 check passed
@ShlomoCode
Copy link
Contributor

ShlomoCode commented Jul 11, 2024 •
edited
Loading

This is a legal and created on purpose. This PR ruined the fix of #124 and more. Cancel it please

@ejbills
Copy link
Owner Author

ejbills commented Jul 11, 2024

This is a legal and created on purpose. This PR ruined the fix of #124 and more. Cancel it please

I will revert, do you want to fix the formatting?

ejbills added a commit that referenced this pull request Jul 11, 2024
@ejbills
Revert "fix: invalid formatting in changelog (#147)"
390f341 
This reverts commit 50ff95d.
@ejbills ejbills mentioned this pull request Jul 11, 2024
Merged
ejbills added a commit that referenced this pull request Jul 11, 2024
@ejbills
Revert "fix: invalid formatting in changelog (#147)" (#149)
e607a27 
This reverts commit 50ff95d.
@ShlomoCode
Copy link
Contributor

ShlomoCode commented Jul 11, 2024 •
edited
Loading

What problems do you think there are in the formatting?
CleanShot 2024-07-11 at 05 43 29@2x

@ejbills
Copy link
Owner Author

ejbills commented Jul 11, 2024

https://github.com/ejbills/DockDoor/blob/main/CHANGELOG.md

The MD is has some html tags on top, I'm not sure why.

@ejbills
Copy link
Owner Author

ejbills commented Jul 11, 2024

IMG_4129

@ShlomoCode
Copy link
Contributor

Yes, because GitHub Markdown does not support style tags
There should be a better solution... but it seems to me that for now it's more important that the changes are display to the simple end user properly

@ShlomoCode
Copy link
Contributor

I think the right solution is jekyll layouts, but I have no experience with that.

@ejbills
Copy link
Owner Author

ejbills commented Jul 11, 2024

Yes, because GitHub Markdown does not support style tags There should be a better solution... but it seems to me that for now it's more important that the changes are display to the simple end user properly

Yeah, I agree with that... apologies for breaking the layout haha

@ejbills ejbills deleted the ejbills-patch-1 branch July 11, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejbills @ShlomoCode