Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD: Rename YAML file #1078

Closed
wants to merge 1 commit into from
Closed

RTD: Rename YAML file #1078

wants to merge 1 commit into from

Conversation

pllim
Copy link
Collaborator

@pllim pllim commented Dec 4, 2023

I think this is required for RTD to build now.

@pllim pllim added this to the 5.0 milestone Dec 4, 2023
@pllim
Copy link
Collaborator Author

pllim commented Dec 4, 2023

I still do not see the RTD job here. Could be the webhook is broken but I cannot see the GitHub admin settings here. On RTD site, it is getting Error 400 .

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Webhook is still enabled, but is showing the error that 400 is happening on the RTD side.

BTW, there is still a travis web hook--not using that now are we? Should we delete it? It's showing invalid HTTP response 503.
Also, the appveyor one is also signalling an error: invalid HTTP response 403

@pllim
Copy link
Collaborator Author

pllim commented Dec 4, 2023

You do not need Travis CI or Appveyor CI webhooks.

You do, however, need to fix the ReadTheDocs webhook. I couldn't fix it from the RTD side. What is it saying on the GitHub side?

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

"Last delivery was not successful. Invalid HTTP response: 400."

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Let me poke around the RTD side...

@pllim
Copy link
Collaborator Author

pllim commented Dec 4, 2023

Is it complaining about invalid token on GH side?

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Shows "passing" on RTD side.

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Is it complaining about invalid token on GH side

Not that I can see anywhere.

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

There is no secret in the secret box, however

@pllim
Copy link
Collaborator Author

pllim commented Dec 4, 2023

Do you see this?

Screenshot 2023-12-04 172712

If so:

  1. Click Change Secret.
  2. Leave blank.
  3. Update Webhook.
  4. Then you can test it by re-deploying the last failed delivery.

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

No, this:
image

@pllim
Copy link
Collaborator Author

pllim commented Dec 4, 2023

Hmm why is it not JSON?

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

I just kicked off a build on RTD of "latest". Double-checked that it is the correct SHA. It used the command "cat .readthedocs.yml" and successfully completed the build. So I don't think the file extension is the issue...

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Should I try switch to JSON?

@pllim
Copy link
Collaborator Author

pllim commented Dec 4, 2023

OK closing this PR then.

Should I try switch to JSON?

Doesn't hurt at this point. 😅

@pllim pllim closed this Dec 4, 2023
@pllim pllim deleted the fix-rtd branch December 4, 2023 22:55
@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Ok, I rebased #1076 and force pushed it. Let's see what happens...

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Still getting a 400 code from RTD...

@pllim
Copy link
Collaborator Author

pllim commented Dec 4, 2023

Looks like it is still failing. There is a message on the RTD integration page for the webhook:

This integration is not managed by Read the Docs currently. If this integration is not functioning correctly, you can try re-syncing it. Otherwise you'll need to update the configuration on your repository. You can use the following address to manually configure this webhook.

To manually configure this webhook with your provider, use the following information...

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Ah, there was a secret there--I have pasted this into the github side. I'll try force pushing #1076 again.

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

On the RTD side, for the HTTP 400 failures, it is showing the following message:

{
  "detail": "Payload not valid, invalid or missing signature"
}

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Under Integrations/Exchange--can you see it?

@ejeschke
Copy link
Owner

ejeschke commented Dec 4, 2023

Hmmm, thinking I might have to try the solution here...

@pllim
Copy link
Collaborator Author

pllim commented Dec 5, 2023

Might as well give that a try. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants