Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Translation and Fix Typo #80

Closed
wants to merge 5 commits into from
Closed

Update Translation and Fix Typo #80

wants to merge 5 commits into from

Conversation

ZhijieWang
Copy link
Contributor

No description provided.

responsibilties -- > responsibilities

exlude -> exclude
@ZhijieWang ZhijieWang mentioned this pull request Oct 24, 2015
@adam-waldenberg
Copy link
Member

Almost. Add the typo fix to the source code as well (these strings are fetched from the source code). This particular line comes from responsibilities.py.

@adam-waldenberg
Copy link
Member

One more thing; "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"... Should be the date the .po was created/updated.

@adam-waldenberg
Copy link
Member

I quickly went over the translation just now. Looking at the po, it's still not using the latest .pot strings. For example the new documentation added to "-f" is missing.

@ZhijieWang
Copy link
Contributor Author

class ResponsibiltyEntry(object):

The class name change may cause way more problems.

@adam-waldenberg
Copy link
Member

Sorry. Wrong file, my misstake... The line you need to modify is the following:

https://github.com/ejwa/gitinspector/blob/master/gitinspector/output/responsibilitiesoutput.py#L28

@ZhijieWang
Copy link
Contributor Author

Updated

@adam-waldenberg
Copy link
Member

Looks good. It's in need of some squashing before merging... I'll take care of this tomorrow.

@adam-waldenberg
Copy link
Member

Thank you. Merged with commits 5ee5127 and 75b528a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants